Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 623993002: Extend snapshot creation to generate 4-byte values (Closed)

Created:
6 years, 2 months ago by baixo
Modified:
6 years, 2 months ago
Reviewers:
rmcilroy, Yang, vogelheim
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Extend snapshot creation to generate 4-byte values R=rmcilroy@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24401

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ross' comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M tools/js2c.py View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
baixo
Please take a look.
6 years, 2 months ago (2014-10-03 16:22:28 UTC) #2
rmcilroy
lgtm with one comment - I'll leave it for yang on Daniel to approve though. ...
6 years, 2 months ago (2014-10-03 16:51:35 UTC) #3
baixo
Addressed Ross' comment. https://codereview.chromium.org/623993002/diff/1/tools/js2c.py File tools/js2c.py (right): https://codereview.chromium.org/623993002/diff/1/tools/js2c.py#newcode502 tools/js2c.py:502: size = 4 On 2014/10/03 16:51:35, ...
6 years, 2 months ago (2014-10-03 19:21:46 UTC) #4
Yang
On 2014/10/03 19:21:46, baixo wrote: > Addressed Ross' comment. > > https://codereview.chromium.org/623993002/diff/1/tools/js2c.py > File tools/js2c.py ...
6 years, 2 months ago (2014-10-04 10:03:30 UTC) #5
Yang
6 years, 2 months ago (2014-10-04 10:30:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 24401 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698