Extend snapshot creation to generate 4-byte values

tools/js2c.py

 #!/usr/bin/env python
 #
 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 480 matching lines @@
   sources_bytes = "".join(sources.modules)
   if compression_type == "off":
     return sources_bytes
   elif compression_type == "bz2":
     return bz2.compress(sources_bytes)
   else:
     raise Error("Unknown compression type %s." % compression_type)
 
 
 def PutInt(blob_file, value):
-  assert(value >= 0 and value < (1 << 20))
-  size = 1 if (value < 1 << 6) else (2 if (value < 1 << 14) else 3)
-  value_with_length = (value << 2) | size
+  assert(value >= 0 and value < (1 << 28))
+  size = 4

[rmcilroy, 2014/10/03 16:51:35]

nit - please move this into an else branch below

[baixo, 2014/10/03 19:21:46]

Done.

+  if (value < 1 << 6):
+    size = 1
+  elif (value < 1 << 14):
+    size = 2
+  elif (value < 1 << 22):
+    size = 3
+  value_with_length = (value << 2) | (size - 1)
 
   byte_sequence = bytearray()
   for i in xrange(size):
     byte_sequence.append(value_with_length & 255)
     value_with_length >>= 8;
   blob_file.write(byte_sequence)
 
 
 def PutStr(blob_file, value):
   PutInt(blob_file, len(value));
@@ skipping 55 matching lines @@
       type: type parameter for NativesCollection template.
       compression: type of compression used. [off|bz2]
       sources.js: JS internal sources or macros.py.""")
   (options, args) = parser.parse_args()
 
   JS2C(args[3:], args[0], args[1], args[2], options.raw, options.startup_blob)
 
 
 if __name__ == "__main__":
   main()