Avoid some explicit WebSpeechRecognitionHandle() conversions.

Avoid some explicit WebSpeechRecognitionHandle() conversions.

It's now tidier to have these be implicit instead.

Also remove an unused WebSpeechGrammar() constructor + some Speech API
assignment operators.

R=
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183242

[sof, 2014-10-05 19:31:11]

sigbjornf@opera.com changed reviewers:
+ tkent@chromium.org

[sof, 2014-10-05 19:31:11]

Please take a look.

Very low priority; just providing implicit&trivial conversions from Speech API
types to their corresponding "Web" wrapper types, rather than explicit.

[Mike West, 2014-10-05 19:37:27]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2014-10-05 19:37:28]

This LGTM % one comment: removing dead code is awesome! You'll still need a web/
OWNER like tkent@ to sign off on it, but hopefully this speeds that up.

https://codereview.chromium.org/623953002/diff/20001/Source/web/SpeechRecogni...
File Source/web/SpeechRecognitionClientProxy.cpp (right):

https://codereview.chromium.org/623953002/diff/20001/Source/web/SpeechRecogni...
Source/web/SpeechRecognitionClientProxy.cpp:41: #include
"public/web/WebSpeechRecognitionHandle.h"
Can you remove the header? It looks like you're just passing
WebSpeechRecognitionHandles around and turning them into SpeechRecognition
objects that you actually use.

[sof, 2014-10-05 20:27:25]

Thanks for the quick (Sunday eve) review, Mike! :)

https://codereview.chromium.org/623953002/diff/20001/Source/web/SpeechRecogni...
File Source/web/SpeechRecognitionClientProxy.cpp (right):

https://codereview.chromium.org/623953002/diff/20001/Source/web/SpeechRecogni...
Source/web/SpeechRecognitionClientProxy.cpp:41: #include
"public/web/WebSpeechRecognitionHandle.h"
On 2014/10/05 19:37:27, Mike West (OOO until 6th) wrote:
> Can you remove the header? It looks like you're just passing
> WebSpeechRecognitionHandles around and turning them into SpeechRecognition
> objects that you actually use.

The declarations for the conversions between WebSpeechRecognitionHandle and
SpeechRecognition* (both ways) need to be in scope here, so it seems reasonable
to include it & not rely on those to float into scope indirectly.

(As it happens, WebSpeechRecognizer.h includes "*Handle.h" - which embedder code
relies on - so it will work out to remove the #include here. But a bit brittle.)

[tkent, 2014-10-05 22:26:46]

The CQ bit was checked by tkent@chromium.org

[tkent, 2014-10-05 22:26:46]

lgtm

[commit-bot: I haz the power, 2014-10-05 22:26:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/623953002/20001

[commit-bot: I haz the power, 2014-10-05 23:28:29]

Committed patchset #2 (id:20001) as 183242