Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(75)

Issue 623833002: Rename FontPlatformDataCocoa and remove fonts/cocoa directory (Closed)

Created:
5 years, 6 months ago by eae
Modified:
5 years, 6 months ago
CC:
blink-reviews, Rik, danakj, krit, jamesr, jbroman, mkwst+moarreviews_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rename FontPlatformDataCocoa and remove fonts/cocoa directory Rename the FontPlatformDataCocoa.mm file to FontPlatformDataMac.mm and move it to the fonts/mac directory where the remaining mac specific font code resides. Also removes the fonts/cocoa directory as this was the last file in that directory. BUG=286450 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183168

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -295 lines) Patch
M Source/platform/blink_platform.gypi View 2 chunks +1 line, -1 line 0 comments Download
D Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm View 1 chunk +0 lines, -294 lines 0 comments Download
A + Source/platform/fonts/mac/FontPlatformDataMac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/platform/fonts/mac/MemoryActivatedFont.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
eae
5 years, 6 months ago (2014-10-02 22:37:20 UTC) #3
dglazkov
lgtm
5 years, 6 months ago (2014-10-02 22:39:12 UTC) #4
leviw_travelin_and_unemployed
My name is Levi and I approve this patch: lgtm. http://i.imgur.com/guj5Fl4.gif
5 years, 6 months ago (2014-10-02 22:39:25 UTC) #5
eae
Thanks guys, you're on fire today! To unsubscribe from this group and stop receiving emails ...
5 years, 6 months ago (2014-10-02 22:43:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623833002/20001
5 years, 6 months ago (2014-10-02 23:21:56 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2014-10-02 23:25:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as 183168

Powered by Google App Engine
This is Rietveld 408576698