Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 623733002: Re-enabling fixed WebRTC getusermedia tests. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enabling fixed WebRTC getusermedia tests. BUG=417756 Committed: https://crrev.com/9fa6d13fdbac6c82917c23c9b63b4f3cb7b7593e Cr-Commit-Position: refs/heads/master@{#298205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -35 lines) Patch
M content/browser/media/webrtc_getusermedia_browsertest.cc View 4 chunks +4 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
phoglund_chromium
6 years, 2 months ago (2014-10-02 14:27:59 UTC) #2
phoglund_chromium
6 years, 2 months ago (2014-10-02 14:28:58 UTC) #4
kjellander_chromium
lgtm, please spend some time monitoring the next runs when landing.
6 years, 2 months ago (2014-10-02 16:08:25 UTC) #6
perkj_chrome
lgtm
6 years, 2 months ago (2014-10-03 12:57:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623733002/1
6 years, 2 months ago (2014-10-06 07:44:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9359db1df26d82a691d271528aec251d4a9640d4
6 years, 2 months ago (2014-10-06 09:14:23 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9fa6d13fdbac6c82917c23c9b63b4f3cb7b7593e Cr-Commit-Position: refs/heads/master@{#298205}
6 years, 2 months ago (2014-10-06 09:15:22 UTC) #11
jam
6 years, 2 months ago (2014-10-06 17:21:08 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/630143002/ by jam@chromium.org.

The reason for reverting is: still flaky, see bug.

Powered by Google App Engine
This is Rietveld 408576698