Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: content/browser/media/webrtc_getusermedia_browsertest.cc

Issue 623733002: Re-enabling fixed WebRTC getusermedia tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/webrtc_getusermedia_browsertest.cc
diff --git a/content/browser/media/webrtc_getusermedia_browsertest.cc b/content/browser/media/webrtc_getusermedia_browsertest.cc
index bbfddf52edb70a29e30639a500336dc177099277..f8cf5557c363cb8c16d90ff34207999649e91f70 100644
--- a/content/browser/media/webrtc_getusermedia_browsertest.cc
+++ b/content/browser/media/webrtc_getusermedia_browsertest.cc
@@ -298,15 +298,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
kRenderDuplicatedMediastreamAndStop));
}
-// Flaky on Android. http://crbug.com/387895
-#if defined(OS_ANDROID)
-#define MAYBE_GetAudioAndVideoStreamAndStop DISABLED_GetAudioAndVideoStreamAndStop
-#else
-#define MAYBE_GetAudioAndVideoStreamAndStop GetAudioAndVideoStreamAndStop
-#endif
-
IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
- MAYBE_GetAudioAndVideoStreamAndStop) {
+ GetAudioAndVideoStreamAndStop) {
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
@@ -439,16 +432,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest, TwoGetUserMediaAndStop) {
"twoGetUserMediaAndStop({video: true, audio: true});");
}
-#if defined(OS_WIN) && !defined(NDEBUG)
-// Flaky on Webkit Win7 Debug bot: http://crbug.com/417756
-#define MAYBE_TwoGetUserMediaWithEqualConstraints \
- DISABLED_TwoGetUserMediaWithEqualConstraints
-#else
-#define MAYBE_TwoGetUserMediaWithEqualConstraints \
- TwoGetUserMediaWithEqualConstraints
-#endif
IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
- MAYBE_TwoGetUserMediaWithEqualConstraints) {
+ TwoGetUserMediaWithEqualConstraints) {
std::string constraints1 = "{video: true, audio: true}";
const std::string& constraints2 = constraints1;
std::string expected_result = "w=640:h=480-w=640:h=480";
@@ -457,16 +442,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
expected_result);
}
-#if defined(OS_WIN)
-// Flaky on Windows Debug: http://crbug.com/417756
-#define MAYBE_TwoGetUserMediaWithSecondVideoCropped \
- DISABLED_TwoGetUserMediaWithSecondVideoCropped
-#else
-#define MAYBE_TwoGetUserMediaWithSecondVideoCropped \
- TwoGetUserMediaWithSecondVideoCropped
-#endif
IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
- MAYBE_TwoGetUserMediaWithSecondVideoCropped) {
+ TwoGetUserMediaWithSecondVideoCropped) {
std::string constraints1 = "{video: true}";
std::string constraints2 = "{video: {mandatory: {maxHeight: 360}}}";
std::string expected_result = "w=640:h=480-w=640:h=360";
@@ -474,16 +451,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
expected_result);
}
-#if defined(OS_WIN) || (defined(OS_LINUX) && !defined(NDEBUG))
-// Flaky on Windows and on Linux Debug: http://crbug.com/417756
-#define MAYBE_TwoGetUserMediaWithFirstHdSecondVga \
- DISABLED_TwoGetUserMediaWithFirstHdSecondVga
-#else
-#define MAYBE_TwoGetUserMediaWithFirstHdSecondVga \
- TwoGetUserMediaWithFirstHdSecondVga
-#endif
IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
- MAYBE_TwoGetUserMediaWithFirstHdSecondVga) {
+ TwoGetUserMediaWithFirstHdSecondVga) {
std::string constraints1 =
"{video: {mandatory: {minWidth:1280 , minHeight: 720}}}";
std::string constraints2 =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698