Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 623683002: Mixed Content: Extract frame processing from ::shouldBlockFetch. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Mixed Content: Extract frame processing from ::shouldBlockFetch. In order to break MixedContentChecker's dependency on LocalFrame, we need to replace the existing checking mechanisms with static calls. This patch extracts some of the logic from ::shouldBlockFetch that we'll need to reuse for blocking WebSockets and form actions in future CLs. ------------------------------------------------------------------------ This was originally landed in https://codereview.chromium.org/566533003, but reverted due to hard-to-track-down ChromeOS issues. I'll re-land it in parts to narrow down the bits that caused problems. ------------------------------------------------------------------------ BUG=411184 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183268

Patch Set 1 #

Patch Set 2 : Fixing preloader. #

Messages

Total messages: 10 (4 generated)
Mike West
Hey Jochen, I want to get started relanding https://codereview.chromium.org/566533003. I'll break it up into chunks ...
6 years, 2 months ago (2014-10-02 10:33:04 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-02 10:59:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623683002/1
6 years, 2 months ago (2014-10-02 11:01:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/27435)
6 years, 2 months ago (2014-10-02 12:14:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623683002/20001
6 years, 2 months ago (2014-10-06 12:28:34 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 13:33:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183268

Powered by Google App Engine
This is Rietveld 408576698