Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 623663002: [ServiceWorker] pipe RequestContext and FrameType to ServiceWorker. [2/2 chromium] (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, mkwst+moarreviews-ipc_chromium.org, mkwst+moarreviews-renderer_chromium.org, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] pipe RequestContext and FrameType to ServiceWorker. [2/2 chromium] [1/2] blink: https://codereview.chromium.org/625513002/ [2/2] chromium: https://codereview.chromium.org/623663002/ BUG=411174, 418469 Committed: https://crrev.com/e392d346bbf526a02bedca7e5577b7d96f154ffc Cr-Commit-Position: refs/heads/master@{#298000}

Patch Set 1 #

Patch Set 2 : Add header files and update gyp #

Patch Set 3 : rebase #

Patch Set 4 : fix unit tests #

Total comments: 2

Patch Set 5 : rebase #

Patch Set 6 : #

Patch Set 7 : request_info.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -10 lines) Patch
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.h View 1 2 3 4 5 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 2 3 4 5 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 2 3 4 5 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.cc View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 1 2 3 4 5 2 chunks +16 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 2 3 4 5 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 1 2 3 4 5 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M content/child/request_info.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M content/child/request_info.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 2 3 4 5 2 chunks +89 lines, -0 lines 0 comments Download
M content/common/content_param_traits_macros.h View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M content/common/resource_messages.h View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_types.cc View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A content/public/common/request_context_frame_type.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
A content/public/common/request_context_type.h View 1 2 3 4 5 1 chunk +50 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 1 2 3 4 5 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
horo
mkwst@ Could you please review this?
6 years, 2 months ago (2014-10-02 08:36:39 UTC) #2
Mike West
LGTM, pretty straightforward piping. I'm glad to see you using the compile assert to static_cast ...
6 years, 2 months ago (2014-10-02 08:46:48 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-02 08:48:21 UTC) #5
Tom Sepez
Messages LGTM otherwise. https://codereview.chromium.org/623663002/diff/60001/content/common/content_param_traits_macros.h File content/common/content_param_traits_macros.h (right): https://codereview.chromium.org/623663002/diff/60001/content/common/content_param_traits_macros.h#newcode26 content/common/content_param_traits_macros.h:26: IPC_ENUM_TRAITS_MAX_VALUE(content::RequestContext, nit: I was suprised that ...
6 years, 2 months ago (2014-10-02 17:35:13 UTC) #6
horo
https://codereview.chromium.org/623663002/diff/60001/content/common/content_param_traits_macros.h File content/common/content_param_traits_macros.h (right): https://codereview.chromium.org/623663002/diff/60001/content/common/content_param_traits_macros.h#newcode26 content/common/content_param_traits_macros.h:26: IPC_ENUM_TRAITS_MAX_VALUE(content::RequestContext, On 2014/10/02 17:35:13, Tom Sepez wrote: > nit: ...
6 years, 2 months ago (2014-10-03 01:58:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623663002/120001
6 years, 2 months ago (2014-10-03 02:07:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/22259)
6 years, 2 months ago (2014-10-03 03:30:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623663002/140001
6 years, 2 months ago (2014-10-03 06:18:58 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:140001) as 6b57ac4f3bdaeaf06902e570b81c3d0885737c89
6 years, 2 months ago (2014-10-03 06:23:32 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 06:24:20 UTC) #16
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/e392d346bbf526a02bedca7e5577b7d96f154ffc
Cr-Commit-Position: refs/heads/master@{#298000}

Powered by Google App Engine
This is Rietveld 408576698