Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 623613005: Don't report VAAPI failures for UMA for platforms that don't support it. (Closed)

Created:
6 years, 2 months ago by wuchengli
Modified:
6 years, 2 months ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

Don't report VAAPI failures for UMA for platforms that don't support it. On startup, VaapiWrapper::GetSupportedEncodeProfiles is called to query HW encoder capabilities to fill GpuInfo with. On VM test however there is no libva present, so we error out, but also attempt to report an error to UMA, which blocks and the GPU process gets killed by the GPU watchdog. We don't need to report failures on GetSupportedEncodeProfiles however, as we will report them later when we attempt to encode anyway. BUG=402182 TEST=test lumpy under kvm and check chrome is not blocked by GetSupportedEncodeProfiles TBR=posciak@chromium.org Review URL: https://codereview.chromium.org/613223002 Cr-Commit-Position: refs/heads/master@{#297564} (cherry picked from commit 4505d0f3dc0bd9b96db7275f0ae33b7f841ebaf1) Committed: https://chromium.googlesource.com/chromium/src/+/b29448409ee02ba02f3768182ff38931d1d7898b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/gpu/media/vaapi_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
wuchengli
6 years, 2 months ago (2014-10-02 04:43:41 UTC) #2
wuchengli
6 years, 2 months ago (2014-10-02 04:45:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b29448409ee02ba02f3768182ff38931d1d7898b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698