Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 613223002: Don't report VAAPI failures to UMA for platforms that don't support it (Closed)

Created:
6 years, 2 months ago by henryhsu
Modified:
6 years, 2 months ago
Reviewers:
wuchengli, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't report VAAPI failures for UMA for platforms that don't support it. On startup, VaapiWrapper::GetSupportedEncodeProfiles is called to query HW encoder capabilities to fill GpuInfo with. On VM test however there is no libva present, so we error out, but also attempt to report an error to UMA, which blocks and the GPU process gets killed by the GPU watchdog. We don't need to report failures on GetSupportedEncodeProfiles however, as we will report them later when we attempt to encode anyway. BUG=402182 TEST=test lumpy under kvm and check chrome is not blocked by GetSupportedEncodeProfiles Committed: https://crrev.com/4505d0f3dc0bd9b96db7275f0ae33b7f841ebaf1 Cr-Commit-Position: refs/heads/master@{#297564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/gpu/media/vaapi_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
henryhsu
PTAL. How to use buildbot to verify entire flow?
6 years, 2 months ago (2014-09-30 13:43:49 UTC) #2
wuchengli
What's the complete stack trace when it hanged? Why does it hangs in VM but ...
6 years, 2 months ago (2014-09-30 14:34:36 UTC) #3
wuchengli
s/blocking function in GetSupportedEncodeProfiles/GetSupportedEncodeProfiles hangs/
6 years, 2 months ago (2014-09-30 14:38:02 UTC) #4
Pawel Osciak
lgtm
6 years, 2 months ago (2014-10-01 00:09:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613223002/1
6 years, 2 months ago (2014-10-01 00:10:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0c0b3394d0b3a7225353353b05515178f485d9aa
6 years, 2 months ago (2014-10-01 01:01:15 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 01:02:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4505d0f3dc0bd9b96db7275f0ae33b7f841ebaf1
Cr-Commit-Position: refs/heads/master@{#297564}

Powered by Google App Engine
This is Rietveld 408576698