Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 623563003: Refactor and delete IOSurface code (Closed)

Created:
6 years, 2 months ago by ccameron
Modified:
6 years, 2 months ago
Reviewers:
Andre
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactor and delete IOSurface code Refactor the IOSurface drawing code because it can now safely assume that the texture it needs to draw is exactly the size of the CALayer. Delete unused and redundant IOSurface code. This should have almost no functional change. BUG= Committed: https://crrev.com/fb55e5ac47d5914bcd8d69e8651210e27ddf5e02 Cr-Commit-Position: refs/heads/master@{#297756}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -260 lines) Patch
M content/browser/compositor/io_surface_context_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/io_surface_layer_mac.mm View 3 chunks +5 lines, -22 lines 0 comments Download
M content/browser/compositor/io_surface_texture_mac.h View 3 chunks +10 lines, -98 lines 0 comments Download
M content/browser/compositor/io_surface_texture_mac.mm View 7 chunks +61 lines, -139 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ccameron
Less trivial change, but still intended to do nothing functional. The next change after this ...
6 years, 2 months ago (2014-10-01 20:11:37 UTC) #2
Andre
On 2014/10/01 20:11:37, ccameron1 wrote: > Less trivial change, but still intended to do nothing ...
6 years, 2 months ago (2014-10-01 20:33:09 UTC) #3
ccameron
Thanks!
6 years, 2 months ago (2014-10-01 23:55:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623563003/20001
6 years, 2 months ago (2014-10-02 00:02:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 85db4ce7ad1d9c77c76ea099e134075d7f2cdc53
6 years, 2 months ago (2014-10-02 01:05:25 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 01:06:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb55e5ac47d5914bcd8d69e8651210e27ddf5e02
Cr-Commit-Position: refs/heads/master@{#297756}

Powered by Google App Engine
This is Rietveld 408576698