Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 623343004: Use the correct fxsave type for x86_64 (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Use the correct fxsave type for x86_64. No functional change. TEST=snapshot_test SystemSnapshotMacTest.CPUX86SupportsDAZ R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/56503fef865d137db5862893ea3998a4ae2c0736

Patch Set 1 #

Patch Set 2 : Update CPUContextX86_64::Fxsave structure #

Patch Set 3 : Simplify #

Patch Set 4 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M snapshot/cpu_context.h View 1 2 3 2 chunks +22 lines, -5 lines 0 comments Download
M snapshot/system_snapshot_mac.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-04 04:17:26 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-06 17:43:52 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-06 17:47:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
56503fef865d137db5862893ea3998a4ae2c0736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698