Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: snapshot/system_snapshot_mac.cc

Issue 623343004: Use the correct fxsave type for x86_64 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Update comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/cpu_context.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/system_snapshot_mac.cc
diff --git a/snapshot/system_snapshot_mac.cc b/snapshot/system_snapshot_mac.cc
index 4c015cac3b4637aff7671a1b0931cb7c91a40233..37b3eca26cb3e8512696f56ad8dc6025ac15b6d3 100644
--- a/snapshot/system_snapshot_mac.cc
+++ b/snapshot/system_snapshot_mac.cc
@@ -270,7 +270,11 @@ bool SystemSnapshotMac::CPUX86SupportsDAZ() const {
}
// Call fxsave.
+#if defined(ARCH_CPU_X86)
CPUContextX86::Fxsave fxsave __attribute__((aligned(16))) = {};
+#elif defined(ARCH_CPU_X86_64)
+ CPUContextX86_64::Fxsave fxsave __attribute__((aligned(16))) = {};
+#endif
static_assert(sizeof(fxsave) == 512, "fxsave size");
static_assert(offsetof(decltype(fxsave), mxcsr_mask) == 28,
"mxcsr_mask offset");
« no previous file with comments | « snapshot/cpu_context.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698