Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1650)

Unified Diff: ash/wm/window_positioner.cc

Issue 62333015: Ensure that the first browser window which is created in Windows 8 ASH is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/window_positioner_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/window_positioner.cc
===================================================================
--- ash/wm/window_positioner.cc (revision 234596)
+++ ash/wm/window_positioner.cc (working copy)
@@ -237,8 +237,13 @@
if (is_saved_bounds)
return;
// When using "small screens" we want to always open in full screen mode.
+ // On Windows 8 ASH we default to SHOW_STATE_MAXIMIZED for the browser
+ // window. This is to ensure that we honor metro app conventions by
+ // default.
if (show_state_in == ui::SHOW_STATE_DEFAULT &&
+#if !defined(OS_WIN)
work_area.width() <= GetForceMaximizedWidthLimit() &&
sky 2013/11/15 16:53:44 Can this be expressed as a property rather than a
ananta 2013/11/15 19:55:17 Done. Added a property kMaximizeFirstWindow to ash
+#endif
(!new_window || !wm::GetWindowState(new_window)->IsFullscreen())) {
*show_state_out = ui::SHOW_STATE_MAXIMIZED;
}
« no previous file with comments | « no previous file | ash/wm/window_positioner_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698