Ensure that the first browser window which is created in Windows 8 ASH is maximized.

ash/wm/window_positioner.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/window_positioner.h"
 
 #include "ash/ash_switches.h"
 #include "ash/screen_ash.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 219 matching lines @@
   // If there is no valid other window we take and adjust the passed coordinates
   // and show state.
   if (!top_window) {
     gfx::Rect work_area = screen->GetDisplayNearestWindow(target).work_area();
 
     bounds_in_out->AdjustToFit(work_area);
     // Use adjusted saved bounds, if there is one.
     if (is_saved_bounds)
       return;
     // When using "small screens" we want to always open in full screen mode.
+    // On Windows 8 ASH we default to SHOW_STATE_MAXIMIZED for the browser
+    // window. This is to ensure that we honor metro app conventions by
+    // default.
     if (show_state_in == ui::SHOW_STATE_DEFAULT &&
+#if !defined(OS_WIN)
         work_area.width() <= GetForceMaximizedWidthLimit() &&

[sky, 2013/11/15 16:53:44]

Can this be expressed as a property rather than a ifdef? Much easier to test and
read.

[ananta, 2013/11/15 19:55:17]

Done. Added a property kMaximizeFirstWindow to ash/wm/window_properties.h. This
is set in the ChromeMetroViewerProcessHost::OnSetTargetSurface function.

+#endif
         (!new_window || !wm::GetWindowState(new_window)->IsFullscreen())) {
       *show_state_out = ui::SHOW_STATE_MAXIMIZED;
     }
     return;
   }
   bool maximized = wm::GetWindowState(top_window)->IsMaximized();
   // We ignore the saved show state, but look instead for the top level
   // window's show state.
   if (show_state_in == ui::SHOW_STATE_DEFAULT) {
     *show_state_out = maximized ? ui::SHOW_STATE_MAXIMIZED :
@@ skipping 279 matching lines @@
   // If the alignment was pushing the window out of the screen, we ignore the
   // alignment for that call.
   if (abs(pos.right() - work_area.right()) < grid)
     x = work_area.right() - w;
   if (abs(pos.bottom() - work_area.bottom()) < grid)
     y = work_area.bottom() - h;
   return gfx::Rect(x, y, w, h);
 }
 
 }  // namespace ash