Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 623243003: Rename isRenderingMaskImage to isRenderingClipPathAsMaskImage (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, krit, gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Rename isRenderingMaskImage to isRenderingClipPathAsMaskImage Also rename the PaintBehavior flag PaintBehaviorRenderingSVGMask to PaintBehaviorRenderingClipPathAsMask. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183272

Patch Set 1 #

Patch Set 2 : -> PaintBehaviorRenderingClipPathAsMask. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/core/rendering/PaintPhase.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
fs
Follow-up to https://codereview.chromium.org/625933003/.
6 years, 2 months ago (2014-10-06 13:08:44 UTC) #2
f(malita)
LGTM We should probably also rename the paint behavior flag (PaintBehaviorRenderingSVGMask).
6 years, 2 months ago (2014-10-06 13:14:55 UTC) #4
fs
On 2014/10/06 13:14:55, Florin Malita wrote: > LGTM > > We should probably also rename ...
6 years, 2 months ago (2014-10-06 13:33:52 UTC) #5
f(malita)
On 2014/10/06 13:33:52, fs wrote: > On 2014/10/06 13:14:55, Florin Malita wrote: > > LGTM ...
6 years, 2 months ago (2014-10-06 13:36:26 UTC) #6
fs
On 2014/10/06 13:36:26, Florin Malita wrote: > On 2014/10/06 13:33:52, fs wrote: > > On ...
6 years, 2 months ago (2014-10-06 13:49:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623243003/20001
6 years, 2 months ago (2014-10-06 13:57:47 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 14:51:06 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183272

Powered by Google App Engine
This is Rietveld 408576698