Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 622883002: Merge FontPlatformDataSkia with FontPlatformData (Closed)

Created:
5 years, 6 months ago by eae
Modified:
5 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, Rik, danakj, krit, jamesr, jbroman, mkwst+moarreviews_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Merge FontPlatformDataSkia with FontPlatformData FontPlatformDataSkia is now compiled on all platforms. Merge it with FontPlatformData. BUG=286450 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183169

Patch Set 1 #

Patch Set 2 : Rebase w/HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -91 lines) Patch
M Source/platform/blink_platform.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/FontPlatformData.cpp View 2 chunks +52 lines, -0 lines 0 comments Download
D Source/platform/fonts/skia/FontPlatformDataSkia.cpp View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
eae
5 years, 6 months ago (2014-10-02 20:52:13 UTC) #2
pdr.
lgtm
5 years, 6 months ago (2014-10-02 21:14:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622883002/1
5 years, 6 months ago (2014-10-02 21:14:35 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/platform/blink_platform.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 6 months ago (2014-10-02 22:19:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622883002/20001
5 years, 6 months ago (2014-10-02 22:25:47 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2014-10-03 00:33:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183169

Powered by Google App Engine
This is Rietveld 408576698