Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 62283010: Remove preemption thread and API (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -316 lines) Patch
M include/v8.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/d8.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/d8.cc View 1 3 chunks +0 lines, -50 lines 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/isolate.h View 3 chunks +0 lines, -8 lines 0 comments Download
M src/isolate.cc View 1 4 chunks +0 lines, -12 lines 0 comments Download
M src/v8threads.h View 1 chunk +0 lines, -28 lines 0 comments Download
M src/v8threads.cc View 2 chunks +0 lines, -70 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +0 lines, -110 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-14 10:02:31 UTC) #1
Sven Panne
https://codereview.chromium.org/62283010/diff/1/include/v8.h File include/v8.h (left): https://codereview.chromium.org/62283010/diff/1/include/v8.h#oldcode5256 include/v8.h:5256: static void StartPreemption(Isolate* isolate, int every_n_ms); While I fully ...
7 years, 1 month ago (2013-11-14 10:13:16 UTC) #2
jochen (gone - plz use gerrit)
rebased, ptal
7 years, 1 month ago (2013-11-18 10:23:19 UTC) #3
Sven Panne
LGTM. Chrome doesn't use the API, node.js's sources don't contain any calls to it, and ...
7 years, 1 month ago (2013-11-20 13:12:48 UTC) #4
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-21 13:47:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r17967 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698