Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: content/renderer/manifest/manifest_parser.cc

Issue 622813002: [Manifest] Add metrics recording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen_orientation_usage_count
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/manifest/manifest_parser.cc
diff --git a/content/renderer/manifest/manifest_parser.cc b/content/renderer/manifest/manifest_parser.cc
index a68ca2ae72e3fb14b86582ebae006612bfd7d201..5c27fceee6750717518aafb0313ef5070f4eed60 100644
--- a/content/renderer/manifest/manifest_parser.cc
+++ b/content/renderer/manifest/manifest_parser.cc
@@ -12,6 +12,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "content/public/common/manifest.h"
+#include "content/renderer/manifest/manifest_uma_util.h"
#include "ui/gfx/geometry/size.h"
namespace content {
@@ -316,6 +317,8 @@ Manifest ManifestParser::Parse(const base::StringPiece& json,
manifest.icons = ParseIcons(*dictionary, manifest_url);
manifest.gcm_sender_id = ParseGCMSenderID(*dictionary);
+ ManifestUmaUtil::ParsedManifest(manifest);
Miguel Garcia 2014/10/02 14:26:46 since you only parse from one place I would do thi
mlamouri (slow - plz ping) 2014/10/02 15:35:06 Done.
+
return manifest;
}

Powered by Google App Engine
This is Rietveld 408576698