[Manifest] Add metrics recording.

content/renderer/manifest/manifest_parser.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/manifest/manifest_parser.h"
 
 #include "base/json/json_reader.h"
 #include "base/strings/nullable_string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "content/public/common/manifest.h"
+#include "content/renderer/manifest/manifest_uma_util.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace content {
 
 namespace {
 
 enum TrimType {
   Trim,
   NoTrim
 };
@@ skipping 284 matching lines @@
   Manifest manifest;
 
   manifest.name = ParseName(*dictionary);
   manifest.short_name = ParseShortName(*dictionary);
   manifest.start_url = ParseStartURL(*dictionary, manifest_url, document_url);
   manifest.display = ParseDisplay(*dictionary);
   manifest.orientation = ParseOrientation(*dictionary);
   manifest.icons = ParseIcons(*dictionary, manifest_url);
   manifest.gcm_sender_id = ParseGCMSenderID(*dictionary);
 
+  ManifestUmaUtil::ParsedManifest(manifest);

[Miguel Garcia, 2014/10/02 14:26:46]

since you only parse from one place I would do this at the caller site. and
depending on wether you got a a full manifest or an empty one log a manifest
valid or manifest error code.
RIght now all you have is wether the manifest is empty but you don't log parsing
errors (since you are returning early above)

[mlamouri (slow - plz ping), 2014/10/02 15:35:06]

Done.

+
   return manifest;
 }
 
 } // namespace content