content/shell/browser/layout_test/layout_test_notification_manager.cc - Issue 622793002: Group the different permission related methods in the content api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_notification_manager.cc

Issue 622793002: Group the different permission related methods in the content api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/shell/browser/layout_test/layout_test_content_browser_client.cc ('K') | « content/shell/browser/layout_test/layout_test_notification_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_notification_manager.cc

diff --git a/content/shell/browser/layout_test/layout_test_notification_manager.cc b/content/shell/browser/layout_test/layout_test_notification_manager.cc

index 99a6a23f7b63180d9a415dbfc2e277765a3b8df8..4ab99387c68a9d844b348816ea73b29bbc367161 100644

--- a/content/shell/browser/layout_test/layout_test_notification_manager.cc

+++ b/content/shell/browser/layout_test/layout_test_notification_manager.cc

@@ -22,8 +22,9 @@ LayoutTestNotificationManager::CheckPermission(const GURL& origin) {

void LayoutTestNotificationManager::RequestPermission(

const GURL& origin,

- const base::Callback<void(blink::WebNotificationPermission)>& callback) {

- callback.Run(CheckPermission(origin));

+ const base::Callback<void(bool)>& callback) {

+ callback.Run(

+ (CheckPermission(origin) == blink::WebNotificationPermissionAllowed));

Peter Beverloo 2014/10/24 14:37:28 Why the extra parenthesis here? Can we use a local

Miguel Garcia 2014/10/24 16:05:32 Done.

}

void LayoutTestNotificationManager::SetPermission(