Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Side by Side Diff: content/shell/browser/layout_test/layout_test_notification_manager.cc

Issue 622793002: Group the different permission related methods in the content api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/browser/layout_test/layout_test_notification_manager.h" 5 #include "content/shell/browser/layout_test/layout_test_notification_manager.h"
6 6
7 namespace content { 7 namespace content {
8 8
9 LayoutTestNotificationManager::LayoutTestNotificationManager() {} 9 LayoutTestNotificationManager::LayoutTestNotificationManager() {}
10 10
11 LayoutTestNotificationManager::~LayoutTestNotificationManager() {} 11 LayoutTestNotificationManager::~LayoutTestNotificationManager() {}
12 12
13 blink::WebNotificationPermission 13 blink::WebNotificationPermission
14 LayoutTestNotificationManager::CheckPermission(const GURL& origin) { 14 LayoutTestNotificationManager::CheckPermission(const GURL& origin) {
15 NotificationPermissionMap::iterator iter = 15 NotificationPermissionMap::iterator iter =
16 permission_map_.find(origin); 16 permission_map_.find(origin);
17 if (iter == permission_map_.end()) 17 if (iter == permission_map_.end())
18 return blink::WebNotificationPermissionDefault; 18 return blink::WebNotificationPermissionDefault;
19 19
20 return iter->second; 20 return iter->second;
21 } 21 }
22 22
23 void LayoutTestNotificationManager::RequestPermission( 23 void LayoutTestNotificationManager::RequestPermission(
24 const GURL& origin, 24 const GURL& origin,
25 const base::Callback<void(blink::WebNotificationPermission)>& callback) { 25 const base::Callback<void(bool)>& callback) {
26 callback.Run(CheckPermission(origin)); 26 callback.Run(
27 (CheckPermission(origin) == blink::WebNotificationPermissionAllowed));
Peter Beverloo 2014/10/24 14:37:28 Why the extra parenthesis here? Can we use a local
Miguel Garcia 2014/10/24 16:05:32 Done.
27 } 28 }
28 29
29 void LayoutTestNotificationManager::SetPermission( 30 void LayoutTestNotificationManager::SetPermission(
30 const GURL& origin, 31 const GURL& origin,
31 blink::WebNotificationPermission permission) { 32 blink::WebNotificationPermission permission) {
32 permission_map_[origin] = permission; 33 permission_map_[origin] = permission;
33 } 34 }
34 35
35 void LayoutTestNotificationManager::ClearPermissions() { 36 void LayoutTestNotificationManager::ClearPermissions() {
36 permission_map_.clear(); 37 permission_map_.clear();
37 } 38 }
38 39
39 } // namespace content 40 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698