Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: content/browser/media/cdm/browser_cdm_manager.cc

Issue 622793002: Group the different permission related methods in the content api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/cdm/browser_cdm_manager.cc
diff --git a/content/browser/media/cdm/browser_cdm_manager.cc b/content/browser/media/cdm/browser_cdm_manager.cc
index ff88aba0c32426390fe3c1f68a1931692888abb3..0c579feada9b05cfea546293a1d1fc448171af9c 100644
--- a/content/browser/media/cdm/browser_cdm_manager.cc
+++ b/content/browser/media/cdm/browser_cdm_manager.cc
@@ -252,20 +252,18 @@ void BrowserCdmManager::OnCreateSession(
RenderFrameHost::FromID(render_process_id_, render_frame_id);
WebContents* web_contents = WebContents::FromRenderFrameHost(rfh);
DCHECK(web_contents);
-
- base::Closure cancel_callback;
- GetContentClient()->browser()->RequestProtectedMediaIdentifierPermission(
+ GetContentClient()->browser()->RequestPermission(
+ content::PERMISSION_PROTECTED_MEDIA,
web_contents,
+ 0 /* bridge id */,
security_origin,
+ /* only implemented for android infobars which do not support
+ user gesture */
+ true,
Bernhard Bauer 2014/10/20 14:57:24 You could extract this to a local variable and put
Bernhard Bauer 2014/10/23 08:38:01 ^^^
Miguel Garcia 2014/10/23 12:48:11 I thought it was just a suggestion and decided not
Bernhard Bauer 2014/10/23 12:54:53 Fair enough. I wasn't sure whether you had seen it
base::Bind(&BrowserCdmManager::CreateSessionIfPermitted,
this,
render_frame_id, cdm_id, session_id,
- mime_type, init_data),
- &cancel_callback);
-
- if (cancel_callback.is_null())
- return;
- cdm_cancel_permission_map_[GetId(render_frame_id, cdm_id)] = cancel_callback;
+ mime_type, init_data));
}
void BrowserCdmManager::OnUpdateSession(

Powered by Google App Engine
This is Rietveld 408576698