Group the different permission related methods in the content api.

content/browser/media/cdm/browser_cdm_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/cdm/browser_cdm_manager.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/task_runner.h"
@@ skipping 234 matching lines @@
     NOTREACHED();
     SendSessionError(render_frame_id, cdm_id, session_id);
     return;
   }
   GURL security_origin = iter->second;
 
   RenderFrameHost* rfh =
       RenderFrameHost::FromID(render_process_id_, render_frame_id);
   WebContents* web_contents = WebContents::FromRenderFrameHost(rfh);
   DCHECK(web_contents);
-
-  base::Closure cancel_callback;
-  GetContentClient()->browser()->RequestProtectedMediaIdentifierPermission(
+  GetContentClient()->browser()->RequestPermission(
+      content::PERMISSION_PROTECTED_MEDIA,
       web_contents,
+      0 /* bridge id */,
       security_origin,
+      /* only implemented for android infobars which do not support
+         user gesture */
+      true,

[Bernhard Bauer, 2014/10/20 14:57:24]

You could extract this to a local variable and put the comment before it.

[Bernhard Bauer, 2014/10/23 08:38:01]

^^^

[Miguel Garcia, 2014/10/23 12:48:11]

I thought it was just a suggestion and decided not to go with it :)

[Bernhard Bauer, 2014/10/23 12:54:53]

Fair enough. I wasn't sure whether you had seen it or not.

       base::Bind(&BrowserCdmManager::CreateSessionIfPermitted,
                  this,
                  render_frame_id, cdm_id, session_id,
-                 mime_type, init_data),
-      &cancel_callback);
-
-  if (cancel_callback.is_null())
-    return;
-  cdm_cancel_permission_map_[GetId(render_frame_id, cdm_id)] = cancel_callback;
+                 mime_type, init_data));
 }
 
 void BrowserCdmManager::OnUpdateSession(
     int render_frame_id,
     int cdm_id,
     uint32 session_id,
     const std::vector<uint8>& response) {
   BrowserCdm* cdm = GetCdm(render_frame_id, cdm_id);
   if (!cdm) {
     DLOG(WARNING) << "No CDM found for: " << render_frame_id << ", " << cdm_id;
@@ skipping 94 matching lines @@
     DLOG(WARNING) << "No CDM found for: " << render_frame_id << ", " << cdm_id;
     SendSessionError(render_frame_id, cdm_id, session_id);
     return;
   }
 
   // This could fail, in which case a SessionError will be fired.
   cdm->CreateSession(session_id, content_type, &init_data[0], init_data.size());
 }
 
 }  // namespace content