Index: components/autofill/core/browser/autofill_manager_unittest.cc |
diff --git a/components/autofill/core/browser/autofill_manager_unittest.cc b/components/autofill/core/browser/autofill_manager_unittest.cc |
index c556bf92cee944cecff7142fa7799a5ebb7a733b..8abec2f14cf23f542ce7b102ee016b07df78b885 100644 |
--- a/components/autofill/core/browser/autofill_manager_unittest.cc |
+++ b/components/autofill/core/browser/autofill_manager_unittest.cc |
@@ -15,6 +15,7 @@ |
#include "base/run_loop.h" |
#include "base/strings/string16.h" |
#include "base/strings/string_number_conversions.h" |
+#include "base/strings/string_util.h" |
#include "base/strings/stringprintf.h" |
#include "base/strings/utf_string_conversions.h" |
#include "base/time/time.h" |
@@ -213,6 +214,31 @@ void CreateTestCreditCardFormData(FormData* form, |
} |
} |
+// Helper function to create a form with credit card number spits across 4 input |
+// fields. |
+void CreateTestCreditCardFormWithNumberSplitAcrossFields(FormData* form) { |
+ CreateTestCreditCardFormData(form, true, false); |
+ |
+ // Remove existing card number field. |
+ form->fields.erase(form->fields.begin() + 1); |
+ |
+ // Add new 4 |card_number_field|s to the |form|. |
+ FormFieldData card_number_field; |
+ card_number_field.max_length = 4; |
+ test::CreateTestFormField( |
+ "Card Number", "cardnumber_1", "", "text", &card_number_field); |
+ form->fields.insert(form->fields.begin() + 1, card_number_field); |
+ |
+ test::CreateTestFormField("", "cardnumber_2", "", "text", &card_number_field); |
+ form->fields.insert(form->fields.begin() + 2, card_number_field); |
+ |
+ test::CreateTestFormField("", "cardnumber_3", "", "text", &card_number_field); |
+ form->fields.insert(form->fields.begin() + 3, card_number_field); |
+ |
+ test::CreateTestFormField("", "cardnumber_4", "", "text", &card_number_field); |
+ form->fields.insert(form->fields.begin() + 4, card_number_field); |
+} |
Ilya Sherman
2014/10/30 01:00:58
Please remove this helper function.
Pritam Nikam
2014/10/30 05:57:18
Done.
Merge within test |GetCreditCardSuggestions
|
+ |
void ExpectFilledField(const char* expected_label, |
const char* expected_name, |
const char* expected_value, |
@@ -898,7 +924,7 @@ TEST_F(AutofillManagerTest, GetCreditCardSuggestionsMatchCharacter) { |
FormsSeen(forms); |
FormFieldData field; |
- test::CreateTestFormField("Card Number", "cardnumber", "4", "text", &field); |
+ test::CreateTestFormField("Card Number", "cardnumber", "78", "text", &field); |
GetAutofillSuggestions(form, field); |
// No suggestions provided, so send an empty vector as the results. |
@@ -2988,4 +3014,35 @@ TEST_F(AutofillManagerTest, TestExternalDelegate) { |
EXPECT_TRUE(external_delegate_->on_query_seen()); |
} |
+// Test to verify suggestions appears for forms having credit card number split |
+// across fields. |
+TEST_F(AutofillManagerTest, GetCreditCardSuggestionsForNumberSpitAcrossFields) { |
+ // Set up our form data with credit card number split across fields. |
+ FormData form; |
+ CreateTestCreditCardFormWithNumberSplitAcrossFields(&form); |
+ std::vector<FormData> forms(1, form); |
+ FormsSeen(forms); |
+ |
+ // Fill the credit card details. |
+ GUIDPair guid("00000000-0000-0000-0000-000000000004", 0); |
+ GUIDPair empty(std::string(), 0); |
+ int response_page_id = 0; |
+ FormData response_data; |
+ FillAutofillFormDataAndSaveResults(kDefaultPageID, |
+ form, |
+ *form.fields.begin(), |
+ PackGUIDs(guid, empty), |
+ &response_page_id, |
+ &response_data); |
+ |
+ ASSERT_EQ(7U, response_data.fields.size()); |
+ |
+ // Verify whether suggestions are populated correctly for one of the middle |
+ // credit card number fields. |
+ FormFieldData number_field = response_data.fields[3]; |
+ |
+ // Suggested card number 4234-5678-9012-3456. |
+ EXPECT_TRUE(StartsWith(number_field.value, ASCIIToUTF16("9012"), false)); |
+} |
Ilya Sherman
2014/10/30 01:00:58
Hmm, this test appears to test that if a suggestio
Pritam Nikam
2014/10/30 05:57:18
Done.
I've restored the GetAutofillSuggestions()
|
+ |
} // namespace autofill |