[Autofill] Autofill fails to show suggestions for credit card split across fields.

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
+#include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/tuple.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/credit_card.h"
@@ skipping 178 matching lines @@
         "Expiration Date", "ccmonth", "", "month", &field);
     form->fields.push_back(field);
   } else {
     test::CreateTestFormField("Expiration Date", "ccmonth", "", "text", &field);
     form->fields.push_back(field);
     test::CreateTestFormField("", "ccyear", "", "text", &field);
     form->fields.push_back(field);
   }
 }
 
+// Helper function to create a form with credit card number spits across 4 input
+// fields.
+void CreateTestCreditCardFormWithNumberSplitAcrossFields(FormData* form) {
+  CreateTestCreditCardFormData(form, true, false);
+
+  // Remove existing card number field.
+  form->fields.erase(form->fields.begin() + 1);
+
+  // Add new 4 |card_number_field|s to the |form|.
+  FormFieldData card_number_field;
+  card_number_field.max_length = 4;
+  test::CreateTestFormField(
+      "Card Number", "cardnumber_1", "", "text", &card_number_field);
+  form->fields.insert(form->fields.begin() + 1, card_number_field);
+
+  test::CreateTestFormField("", "cardnumber_2", "", "text", &card_number_field);
+  form->fields.insert(form->fields.begin() + 2, card_number_field);
+
+  test::CreateTestFormField("", "cardnumber_3", "", "text", &card_number_field);
+  form->fields.insert(form->fields.begin() + 3, card_number_field);
+
+  test::CreateTestFormField("", "cardnumber_4", "", "text", &card_number_field);
+  form->fields.insert(form->fields.begin() + 4, card_number_field);
+}

[Ilya Sherman, 2014/10/30 01:00:58]

Please remove this helper function.

[Pritam Nikam, 2014/10/30 05:57:18]

Done.

Merge within test |GetCreditCardSuggestionsForNumberSpitAcrossFields|.

+
 void ExpectFilledField(const char* expected_label,
                        const char* expected_name,
                        const char* expected_value,
                        const char* expected_form_control_type,
                        const FormFieldData& field) {
   SCOPED_TRACE(expected_label);
   EXPECT_EQ(UTF8ToUTF16(expected_label), field.label);
   EXPECT_EQ(UTF8ToUTF16(expected_name), field.name);
   EXPECT_EQ(UTF8ToUTF16(expected_value), field.value);
   EXPECT_EQ(expected_form_control_type, field.form_control_type);
@@ skipping 665 matching lines @@
 // Test that we return only matching credit card profile suggestions when the
 // selected form field has been partially filled out.
 TEST_F(AutofillManagerTest, GetCreditCardSuggestionsMatchCharacter) {
   // Set up our form data.
   FormData form;
   CreateTestCreditCardFormData(&form, true, false);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   FormFieldData field;
-  test::CreateTestFormField("Card Number", "cardnumber", "4", "text", &field);
+  test::CreateTestFormField("Card Number", "cardnumber", "78", "text", &field);
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   // Test that we sent the right values to the external delegate.
   base::string16 expected_values[] = {ASCIIToUTF16("************3456")};
   base::string16 expected_labels[] = {ASCIIToUTF16("04/12")};
   base::string16 expected_icons[] = {ASCIIToUTF16(kVisaCard)};
@@ skipping 2069 matching lines @@
   FormData form;
   test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);  // should call the delegate's OnQuery()
 
   EXPECT_TRUE(external_delegate_->on_query_seen());
 }
 
+// Test to verify suggestions appears for forms having credit card number split
+// across fields.
+TEST_F(AutofillManagerTest, GetCreditCardSuggestionsForNumberSpitAcrossFields) {
+  // Set up our form data with credit card number split across fields.
+  FormData form;
+  CreateTestCreditCardFormWithNumberSplitAcrossFields(&form);
+  std::vector<FormData> forms(1, form);
+  FormsSeen(forms);
+
+  // Fill the credit card details.
+  GUIDPair guid("00000000-0000-0000-0000-000000000004", 0);
+  GUIDPair empty(std::string(), 0);
+  int response_page_id = 0;
+  FormData response_data;
+  FillAutofillFormDataAndSaveResults(kDefaultPageID,
+                                     form,
+                                     *form.fields.begin(),
+                                     PackGUIDs(guid, empty),
+                                     &response_page_id,
+                                     &response_data);
+
+  ASSERT_EQ(7U, response_data.fields.size());
+
+  // Verify whether suggestions are populated correctly for one of the middle
+  // credit card number fields.
+  FormFieldData number_field = response_data.fields[3];
+
+  // Suggested card number 4234-5678-9012-3456.
+  EXPECT_TRUE(StartsWith(number_field.value, ASCIIToUTF16("9012"), false));
+}

[Ilya Sherman, 2014/10/30 01:00:58]

Hmm, this test appears to test that if a suggestion is selected, then it's
filled correctly.  The comment above the test, however, indicates that what you
wanted to test was that the suggestion is shown in the first place.

[Pritam Nikam, 2014/10/30 05:57:18]

Done.

I've restored the GetAutofillSuggestions() and rest of the code excerpt as it's
required to test PersonalDataManager::GetCreditCardSuggestions().

Here, |autofill_values_| is kept private, hence testing it alone against
suggestions(expected_values) wont be easy. Only way to test is using helper
CheckSuggestions(), that requires expected labels, icons and ids to be supplied
in addition.

+
 }  // namespace autofill