[Autofill] Autofill fails to show suggestions for credit card split across fields.

components/autofill/core/browser/autofill_field.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 68 matching lines @@
   static bool FillFormField(const AutofillField& field,
                             const base::string16& value,
                             const std::string& address_language_code,
                             const std::string& app_locale,
                             FormFieldData* field_data);
 
   // Returns the phone number value for the given |field|. The returned value
   // might be |number|, or could possibly be a prefix or suffix of |number|
   // if that's appropriate for the field.
   static base::string16 GetPhoneNumberValue(const AutofillField& field,
-                                            const base::string16& number,
-                                            const FormFieldData& field_data);
+                                            const base::string16& number);
+
+  // Returns the credit card number value for the given |field|. The returned
+  // value might be |number|, or possibly an appropriate substring of |number|
+  // for cases where credit card number splits across multiple HTML form input
+  // fields.
+  static base::string16 GetCreditCardNumberValue(const AutofillField& field,
+                                                 const base::string16& number);

[Ilya Sherman, 2014/10/28 21:48:40]

It looks like this change is no longer needed as part of this CL.

[Pritam Nikam, 2014/10/29 08:38:16]

Done.

I've created a follow-up CL for this code refactoring/cleanup.
[https://codereview.chromium.org/689573002/]

 
  private:
   // The unique name of this field, generated by Autofill.
   base::string16 unique_name_;
 
   // The unique identifier for the section (e.g. billing vs. shipping address)
   // that this field belongs to.
   std::string section_;
 
   // The type of the field, as determined by the Autofill server.
@@ skipping 21 matching lines @@
   // Used to hold the position of the first digit to be copied as a substring
   // from credit card number.
   size_t credit_card_number_offset_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillField);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_FIELD_H_