Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: components/autofill/core/browser/autofill_field.h

Issue 622773002: [Autofill] Autofill fails to show suggestions for credit card split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed ObfuscatedCreditCardNumber() from AutofillManager. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_field.h
diff --git a/components/autofill/core/browser/autofill_field.h b/components/autofill/core/browser/autofill_field.h
index 1c79bb2fd001fc090115c738fb06e06054185923..7a64ac72b03562a7ffe4951e42e5276b10d041a4 100644
--- a/components/autofill/core/browser/autofill_field.h
+++ b/components/autofill/core/browser/autofill_field.h
@@ -86,8 +86,14 @@ class AutofillField : public FormFieldData {
// might be |number|, or could possibly be a prefix or suffix of |number|
// if that's appropriate for the field.
static base::string16 GetPhoneNumberValue(const AutofillField& field,
- const base::string16& number,
- const FormFieldData& field_data);
+ const base::string16& number);
+
+ // Returns the credit card number value for the given |field|. The returned
+ // value might be |number|, or possibly an appropriate substring of |number|
+ // for cases where credit card number splits across multiple HTML form input
+ // fields.
+ static base::string16 GetCreditCardNumberValue(const AutofillField& field,
+ const base::string16& number);
Ilya Sherman 2014/10/28 21:48:40 It looks like this change is no longer needed as p
Pritam Nikam 2014/10/29 08:38:16 Done. I've created a follow-up CL for this code r
private:
// The unique name of this field, generated by Autofill.

Powered by Google App Engine
This is Rietveld 408576698