Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issue 62273004: Remove call to update_resources.py for WebRTC (Closed)

Created:
7 years, 1 month ago by kjellander_chromium
Modified:
7 years, 1 month ago
Reviewers:
navabi1, navabi
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Remove call to update_resources.py for WebRTC This script is about to be removed in favor of using download_from_google_storage.py in depot tools for the download instead (based on .sha1 files). When https://codereview.chromium.org/60513012/ is landed and the builders are updated to actually execute the hooks (https://codereview.chromium.org/59793009) the resource files will be downloaded using that instead. Even if executing the hooks means a bit of extra execution time for the build, this approach is simpler and means less maintenance. TEST=none BUG=webrtc:2294 NOTRY=True TBR=navabi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233587

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M build/android/buildbot/bb_host_steps.py View 1 chunk +0 lines, -7 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kjellander_chromium
7 years, 1 month ago (2013-11-06 21:00:47 UTC) #1
navabi
lgtm
7 years, 1 month ago (2013-11-06 21:19:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/62273004/30001
7 years, 1 month ago (2013-11-07 11:57:55 UTC) #3
commit-bot: I haz the power
Change committed as 233587
7 years, 1 month ago (2013-11-07 11:59:54 UTC) #4
kjellander_chromium
On 2013/11/07 11:59:54, I haz the power (commit-bot) wrote: > Change committed as 233587 navabi: ...
7 years, 1 month ago (2013-11-07 14:31:42 UTC) #5
navabi1
7 years, 1 month ago (2013-11-08 22:24:50 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698