Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 59793009: Make Android Chromium-APK builders execute the hooks (Closed)

Created:
7 years, 1 month ago by kjellander_chromium
Modified:
7 years, 1 month ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Make Android Chromium-APK builders execute the hooks The resource files are changed to be downloaded using a hook instead of the update_resources.py script (see https://codereview.chromium.org/60513012/) TEST=none BUG=webrtc:2294 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=233580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M masters/master.client.webrtc/master_android_cfg.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kjellander_chromium
7 years, 1 month ago (2013-11-07 09:39:08 UTC) #1
phoglund_chromium
lgtm Why is there no bug id? Can't refer to WebRTC bugs from chromium issues?
7 years, 1 month ago (2013-11-07 10:33:47 UTC) #2
kjellander_chromium
On 2013/11/07 10:33:47, phoglund wrote: > lgtm > > Why is there no bug id? ...
7 years, 1 month ago (2013-11-07 10:53:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/59793009/1
7 years, 1 month ago (2013-11-07 11:47:27 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 11:48:12 UTC) #5
Message was sent while issue was closed.
Change committed as 233580

Powered by Google App Engine
This is Rietveld 408576698