chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc - Issue 622683006: Refactor security interstitials, add SecurityInterstitialPage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Issue 622683006: Refactor security interstitials, add SecurityInterstitialPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad rebase and add owners Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/interstitials/security_interstitial_page.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc ('k') | chrome/browser/ssl/ssl_blocking_page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

index 8fc2e798a3acf7d13c76cde2b5c8d94140125145..536953a5bcc56a381648b9fd31fb4e076962833b 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

@@ -165,14 +165,14 @@ class SafeBrowsingBlockingPageTest : public ChromeRenderViewHostTestHarness {

static void ProceedThroughInterstitial(

SafeBrowsingBlockingPage* sb_interstitial) {

- sb_interstitial->interstitial_page_->Proceed();

+ sb_interstitial->interstitial_page()->Proceed();

// Proceed() posts a task to update the SafeBrowsingService::Client.

base::RunLoop().RunUntilIdle();

}

static void DontProceedThroughInterstitial(

SafeBrowsingBlockingPage* sb_interstitial) {

- sb_interstitial->interstitial_page_->DontProceed();

+ sb_interstitial->interstitial_page()->DontProceed();

// DontProceed() posts a task to update the SafeBrowsingService::Client.

base::RunLoop().RunUntilIdle();

}

@@ -578,8 +578,8 @@ TEST_F(SafeBrowsingBlockingPageTest, ProceedThenDontProceed) {

// Simulate the user clicking "proceed" then "don't proceed" (before the

// interstitial is shown).

- sb_interstitial->interstitial_page_->Proceed();

- sb_interstitial->interstitial_page_->DontProceed();

+ sb_interstitial->interstitial_page()->Proceed();

+ sb_interstitial->interstitial_page()->DontProceed();

// Proceed() and DontProceed() post a task to update the

// SafeBrowsingService::Client.

base::RunLoop().RunUntilIdle();