chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc - Issue 622683006: Refactor security interstitials, add SecurityInterstitialPage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 622683006: Refactor security interstitials, add SecurityInterstitialPage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad rebase and add owners Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/interstitials/security_interstitial_page.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

index 42d0d694d335cc9a087dd5bd18bd66daeaf780ae..7aaa51f990716def1070fa2bb1add4164df9a64b 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

@@ -408,6 +408,8 @@ class SafeBrowsingBlockingPageBrowserTest

InterstitialPage::GetInterstitialPage(contents)->

GetDelegateForTesting());

ASSERT_TRUE(interstitial_page);

+ ASSERT_EQ(SafeBrowsingBlockingPage::kTypeForTesting,

+ interstitial_page->GetTypeForTesting());

interstitial_page->CommandReceived(command);

}

@@ -438,6 +440,8 @@ class SafeBrowsingBlockingPageBrowserTest

TestSafeBrowsingBlockingPage* page =

static_cast<TestSafeBrowsingBlockingPage*>(

contents->GetInterstitialPage()->GetDelegateForTesting());

+ ASSERT_EQ(SafeBrowsingBlockingPage::kTypeForTesting,

+ page->GetTypeForTesting());

page->WaitForDelete();

}