Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 622393002: Introduce new entry-points for non-paint-server RenderSVGResources (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Introduce new entry-points for non-paint-server RenderSVGResources The applyResource/postApplyResource entry-points defined in the RenderSVGResource interface are not of much use to non-paint-server resource-types (clipPath, mask, filter, marker), since they share very little semantic-wise. This also mean that they impede changes that could benefit the "other" type of resource. Make the mentioned methods be used only for the paint-server resources, and move the current functionality for mask/filter (clipPath already has an interface of its own, as does marker) to methods with the names prepareEffect/finishEffect. This removes all actual uses of the RenderSVGResourceMode ApplyToDefaultMode "flag", so drop it. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -46 lines) Patch
M Source/core/rendering/svg/RenderSVGResource.h View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceGradient.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMarker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.h View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
Bikeshed territory...
6 years, 2 months ago (2014-10-03 17:06:23 UTC) #2
pdr.
On 2014/10/03 at 17:06:23, fs wrote: > Bikeshed territory... I think this looks good and ...
6 years, 2 months ago (2014-10-03 17:22:53 UTC) #3
fs
On 2014/10/03 17:22:53, pdr wrote: > On 2014/10/03 at 17:06:23, fs wrote: > > Bikeshed ...
6 years, 2 months ago (2014-10-06 07:58:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622393002/1
6 years, 2 months ago (2014-10-06 09:32:28 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 11:14:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183261

Powered by Google App Engine
This is Rietveld 408576698