Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 622253004: Use a composed tree based traversal in computing quads in LinkHighlight::computeQuads(). (Closed)

Created:
6 years, 2 months ago by hayato
Modified:
6 years, 2 months ago
Reviewers:
esprehn, dglazkov, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromiumbugtracker_adobe.com, dglazkov+blink, eae+blinkwatch, mkwst+moarreviews_chromium.org, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Use a composed tree based traversal in computing quads in LinkHighlight::computeQuads(). This is a follow-up patch for https://codereview.chromium.org/448593002 to fix a crash. The previous patch uses renderer.slowFirstChild() to get an child renderer in computeQuads(). However, this is not always correct. For example, suppose that <a><div></div></a> is given, the render tree would be: RenderBlock (anonymous) 0x6110004a6400 RenderInline 0x60c00014e6c0 A 0x60d00006cf10 RenderBlock (anonymous) 0x6110004a6180 RenderBlock 0x6110004a62c0 DIV 0x60b00004d930 CLASS="_muf" In this case, there is no child renderer for RenderInline object(0x60c00014e6c0). Instead, LinkHighlight::computeQuads() should use a composed tree based traversal to compute quads correctly because we've already used a composed tree based traversal to get an parent object in the previous patch. BUG=417191 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183756

Patch Set 1 #

Patch Set 2 : Fixed #

Patch Set 3 : rebased #

Patch Set 4 : fix the test #

Patch Set 5 : no pixel test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
A LayoutTests/compositing/gestures/gesture-tapHighlight-inline-block-crash.html View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/compositing/gestures/gesture-tapHighlight-inline-block-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/NodeRenderingTraversal.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/NodeRenderingTraversal.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/LinkHighlight.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/LinkHighlight.cpp View 1 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hayato
WIP. LinkHighlightTest.verifyWebViewImplIntegration seemed to fail. Let me take a loot.
6 years, 2 months ago (2014-10-06 07:45:17 UTC) #1
hayato
PTAL. The patch is ready for reviews.
6 years, 2 months ago (2014-10-06 08:28:27 UTC) #3
hayato
Friendly ping. I've fixed the falling layout test. Could someone review this?
6 years, 2 months ago (2014-10-15 04:33:59 UTC) #5
dglazkov
lgtm
6 years, 2 months ago (2014-10-15 15:47:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622253004/80001
6 years, 2 months ago (2014-10-15 15:48:33 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 15:54:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 183756

Powered by Google App Engine
This is Rietveld 408576698