Pass start/length at InlineTextBox construction time.

Pass start/length at InlineTextBox construction time.

This eliminates all but two ways that m_start/m_len can be
changed after construction (markDirty and offsetRun).

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183349

[jbroman, 2014-10-03 14:14:40]

jbroman@chromium.org changed reviewers:
+ fmalita@chromium.org

[jbroman, 2014-10-03 14:14:40]

WDYT? Nobody should have been calling these setters after construction before
anyhow.

[f(malita), 2014-10-06 15:18:23]

LGTM + nit.

https://codereview.chromium.org/622253002/diff/40001/Source/core/rendering/Re...
File Source/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/622253002/diff/40001/Source/core/rendering/Re...
Source/core/rendering/RenderBlockLineLayout.cpp:198: RenderText* text =
toRenderText(r->m_object);
Let's use a helper for this block too (createInlineBoxForText or such).

[jbroman, 2014-10-06 19:07:05]

Patchset #4 (id:60001) has been deleted

[jbroman, 2014-10-06 19:08:48]

https://codereview.chromium.org/622253002/diff/40001/Source/core/rendering/Re...
File Source/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/622253002/diff/40001/Source/core/rendering/Re...
Source/core/rendering/RenderBlockLineLayout.cpp:198: RenderText* text =
toRenderText(r->m_object);
On 2014/10/06 15:18:23, Florin Malita wrote:
> Let's use a helper for this block too (createInlineBoxForText or such).

Done.

[jbroman, 2014-10-06 22:51:38]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2014-10-06 22:52:01]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2014-10-06 22:52:02]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2014-10-06 22:54:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/622253002/100001

[commit-bot: I haz the power, 2014-10-07 02:29:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-07 02:29:37]

Failed to apply patch for Source/core/rendering/InlineTextBox.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/rendering/InlineTextBox.cpp
  Hunk #1 FAILED at 71.
  Hunk #2 succeeded at 81 (offset -1 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/rendering/InlineTextBox.cpp.rej

Patch:       Source/core/rendering/InlineTextBox.cpp
Index: Source/core/rendering/InlineTextBox.cpp
diff --git a/Source/core/rendering/InlineTextBox.cpp
b/Source/core/rendering/InlineTextBox.cpp
index
819ad9d32570409f59b7b74d13d6ffb88dbc4fae..904728fa6905743dff2bf07ee42d3b7c0b084f04
100644
--- a/Source/core/rendering/InlineTextBox.cpp
+++ b/Source/core/rendering/InlineTextBox.cpp
@@ -71,7 +71,6 @@ COMPILE_ASSERT(sizeof(InlineTextBox) ==
sizeof(SameSizeAsInlineTextBox), InlineT
 typedef WTF::HashMap<const InlineTextBox*, LayoutRect>
InlineTextBoxOverflowMap;
 static InlineTextBoxOverflowMap* gTextBoxesWithOverflow;
 
-
 void InlineTextBox::destroy()
 {
     AbstractInlineTextBox::willDestroy(this);
@@ -82,6 +81,13 @@ void InlineTextBox::destroy()
     InlineBox::destroy();
 }
 
+void InlineTextBox::offsetRun(int delta)
+{
+    ASSERT(!isDirty());
+    InlineTextBoxPainter::removeFromTextBlobCache(*this);
+    m_start += delta;
+}
+
 void InlineTextBox::markDirty()
 {
     // FIXME: Is it actually possible to try and paint a dirty InlineTextBox?

[commit-bot: I haz the power, 2014-10-07 02:30:18]

The CQ bit was unchecked by commit-bot@chromium.org

[jbroman, 2014-10-07 14:26:09]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2014-10-07 14:27:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/622253002/120001

[commit-bot: I haz the power, 2014-10-07 16:29:51]

Committed patchset #6 (id:120001) as 183349