check for newSurface failure

bench/DeferredSurfaceCopyBench.cpp

Index: bench/DeferredSurfaceCopyBench.cpp
diff --git a/bench/DeferredSurfaceCopyBench.cpp b/bench/DeferredSurfaceCopyBench.cpp
index cbf98ec8a195c313835d3ebd2b1e552dc3ab2c75..e92e0446e2defbe618c07943c7bb4395def8b058 100644
--- a/bench/DeferredSurfaceCopyBench.cpp
+++ b/bench/DeferredSurfaceCopyBench.cpp
@@ -38,6 +38,12 @@ protected:
         const SkRect fullCanvasRect = SkRect::MakeWH(
             SkIntToScalar(kSurfaceWidth), SkIntToScalar(kSurfaceHeight));
         SkAutoTUnref<SkSurface> surface(canvas->newSurface(info));
+
+        // newSurface() can return NULL for several reasons, so we need to check
+        if (NULL == surface.get()) {
+            return; // should we signal the caller that we hit an error?

[mtklein, 2014/10/02 19:43:08]

Can't hurt to at least log it?

SkDebugf("Surface creation failed, %s bench results will be nonsense.\n",
this->getName());

[reed1, 2014/10/02 19:53:27]

Done.

+        }
+
         SkAutoTUnref<SkDeferredCanvas> drawingCanvas(SkDeferredCanvas::Create(surface));
 
         for (int iteration = 0; iteration < loops; iteration++) {