check for newSurface failure

bench/DeferredSurfaceCopyBench.cpp

 
 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "Benchmark.h"
 #include "SkDeferredCanvas.h"
@@ skipping 20 matching lines @@
             "DeferredSurfaceCopy_nonDiscardable";
     }
 
     virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE {
         // The canvas is not actually used for this test except to provide
         // configuration information: gpu, multisampling, size, etc?
         SkImageInfo info = SkImageInfo::MakeN32Premul(kSurfaceWidth, kSurfaceHeight);
         const SkRect fullCanvasRect = SkRect::MakeWH(
             SkIntToScalar(kSurfaceWidth), SkIntToScalar(kSurfaceHeight));
         SkAutoTUnref<SkSurface> surface(canvas->newSurface(info));
+
+        // newSurface() can return NULL for several reasons, so we need to check
+        if (NULL == surface.get()) {
+            return; // should we signal the caller that we hit an error?

[mtklein, 2014/10/02 19:43:08]

Can't hurt to at least log it?

SkDebugf("Surface creation failed, %s bench results will be nonsense.\n",
this->getName());

[reed1, 2014/10/02 19:53:27]

Done.

+        }
+
         SkAutoTUnref<SkDeferredCanvas> drawingCanvas(SkDeferredCanvas::Create(surface));
 
         for (int iteration = 0; iteration < loops; iteration++) {
             drawingCanvas->clear(0);
             SkAutoTUnref<SkImage> image(drawingCanvas->newImageSnapshot());
             SkPaint paint;
             if (!fDiscardableContents) {
                 // If paint is not opaque, prior canvas contents are
                 // not discardable because they are needed for compositing.
                 paint.setAlpha(127);
             }
             drawingCanvas->drawRect(fullCanvasRect, paint);
             // Trigger copy on write, which should be faster in the discardable case.
             drawingCanvas->flush();
         }
     }
 
 private:
     bool fDiscardableContents;
 
     typedef Benchmark INHERITED;
 };
 
 //////////////////////////////////////////////////////////////////////////////
 
 DEF_BENCH( return new DeferredSurfaceCopyBench(false); )
 DEF_BENCH( return new DeferredSurfaceCopyBench(true); )