check for newSurface failure

check for newSurface failure

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/337c2dd42086c56696c57830bb3953554a973511

[reed1, 2014-10-02 19:41:00]

reed@google.com changed reviewers:
+ junov@google.com, mtklein@google.com

[reed1, 2014-10-02 19:41:04]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-10-02 19:41:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/622063003/20001

[commit-bot: I haz the power, 2014-10-02 19:41:40]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-10-03 01:41 UTC

[mtklein, 2014-10-02 19:43:08]

lgtm

https://codereview.chromium.org/622063003/diff/20001/bench/DeferredSurfaceCop...
File bench/DeferredSurfaceCopyBench.cpp (right):

https://codereview.chromium.org/622063003/diff/20001/bench/DeferredSurfaceCop...
bench/DeferredSurfaceCopyBench.cpp:44: return; // should we signal the caller
that we hit an error?
Can't hurt to at least log it?

SkDebugf("Surface creation failed, %s bench results will be nonsense.\n",
this->getName());

[mtklein, 2014-10-02 19:43:16]

The CQ bit was unchecked by mtklein@google.com

[reed1, 2014-10-02 19:50:31]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-10-02 19:50:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/622063003/40001

[reed1, 2014-10-02 19:53:27]

https://codereview.chromium.org/622063003/diff/20001/bench/DeferredSurfaceCop...
File bench/DeferredSurfaceCopyBench.cpp (right):

https://codereview.chromium.org/622063003/diff/20001/bench/DeferredSurfaceCop...
bench/DeferredSurfaceCopyBench.cpp:44: return; // should we signal the caller
that we hit an error?
On 2014/10/02 19:43:08, mtklein wrote:
> Can't hurt to at least log it?
> 
> SkDebugf("Surface creation failed, %s bench results will be nonsense.\n",
> this->getName());

Done.

[commit-bot: I haz the power, 2014-10-02 19:58:52]

Committed patchset #3 (id:40001) as 337c2dd42086c56696c57830bb3953554a973511