Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 621593003: Prepare to add a use counter for Intl.v8BreakIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Break in switch case Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/Source/bindings/core/v8/V8PerIsolateData.cpp b/Source/bindings/core/v8/V8PerIsolateData.cpp
index d5aa45c6d7d8f79c13d732112242c2243266d8d0..bfca715e18ab407bc1631c1be874600e8220e350 100644
--- a/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -57,7 +57,10 @@ static void useCounterCallback(v8::Isolate* isolate, v8::Isolate::UseCounterFeat
UseCounter::count(currentExecutionContext(isolate), UseCounter::UseAsm);
break;
default:
- ASSERT_NOT_REACHED();
+ // V8 may be a newer version that has some use counters we don't know
+ // about yet. FIXME: Add support for v8::Isolate::kBreakIterator and
+ // UseCounter::BreakIterator.
+ break;
}
}
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698