Issue 62158: Preflight crash fix for bug 9796....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62158: Preflight crash fix for bug 9796.... (Closed)

Created:
11 years, 8 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Preflight crash fix for bug 9796. UniscribeHelperTextRun::characterToX respects RTL scripts, but here we just want the text bounds, so swap 'left' and 'right' as needed to make it so. R=brettw

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	third_party/WebKit/WebCore/platform/graphics/chromium/FontChromiumWin.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 8 months ago (2009-04-08 19:34:35 UTC) #2

LGTM

http://codereview.chromium.org/62158/diff/1/2
File third_party/WebKit/WebCore/platform/graphics/chromium/FontChromiumWin.cpp
(right):

http://codereview.chromium.org/62158/diff/1/2#newcode327
Line 327: // We just want the bounds.
This comment is cryptic. Can you explain the RTL case?

Expand Messages | Collapse Messages