Chromium Code Reviews
Help | Chromium Project | Sign in
(544)

Issue 62158: Preflight crash fix for bug 9796.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by darin
Modified:
2 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Preflight crash fix for bug 9796.

UniscribeHelperTextRun::characterToX respects RTL scripts, but here we just
want the text bounds, so swap 'left' and 'right' as needed to make it so.

R=brettw

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Lint Patch
M third_party/WebKit/WebCore/platform/graphics/chromium/FontChromiumWin.cpp View 1 1 chunk +4 lines, -0 lines 0 comments 1 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
darin
5 years ago #1
brettw
5 years ago #2
LGTM

http://codereview.chromium.org/62158/diff/1/2
File third_party/WebKit/WebCore/platform/graphics/chromium/FontChromiumWin.cpp
(right):

http://codereview.chromium.org/62158/diff/1/2#newcode327
Line 327: // We just want the bounds.
This comment is cryptic. Can you explain the RTL case?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6