Chromium Code Reviews
Help | Chromium Project | Sign in
(71)

Issue 62158: Preflight crash fix for bug 9796.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by darin (slow to review)
Modified:
3 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Preflight crash fix for bug 9796. UniscribeHelperTextRun::characterToX respects RTL scripts, but here we just want the text bounds, so swap 'left' and 'right' as needed to make it so. R=brettw

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/WebCore/platform/graphics/chromium/FontChromiumWin.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
darin (slow to review)
5 years, 11 months ago (2009-04-08 19:02:13 UTC) #1
brettw
5 years, 11 months ago (2009-04-08 19:34:35 UTC) #2
LGTM

http://codereview.chromium.org/62158/diff/1/2
File third_party/WebKit/WebCore/platform/graphics/chromium/FontChromiumWin.cpp
(right):

http://codereview.chromium.org/62158/diff/1/2#newcode327
Line 327: // We just want the bounds.
This comment is cryptic. Can you explain the RTL case?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d