Issue 62154: Implement stop/go button for Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62154: Implement stop/go button for Linux (Closed)

Created:
11 years, 8 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Implement stop/go button for Linux. Refactored code out of CustomDrawButton into CustomDrawButtonBase to be shared with GoButtonGtk. Replaced the existing non-togglable go button with GoButtonGtk. Note that tooltip support isn't done yet, as it changes based on the state of the location bar and the go/stop state. Add a simple test. Fix some minor lint errors. BUG=9381 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13409

Patch Set 1 #

Patch Set 2 : Added a few more comments. #

Patch Set 3 : Add a small DCHECK => DCHECK_NE change. #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+452 lines, -40 lines)			Patch
M	chrome/browser/gtk/browser_toolbar_gtk.h	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/custom_button.h	View	1	2 chunks	+28 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/custom_button.cc	View		3 chunks	+40 lines, -23 lines	0 comments	Download
A	chrome/browser/gtk/go_button_gtk.h	View		1 chunk	+76 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/go_button_gtk.cc	View		1 chunk	+156 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/go_button_gtk_unittest.cc	View		1 chunk	+130 lines, -0 lines	0 comments	Download
M	chrome/browser/views/go_button.h	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/views/go_button.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2	4 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 8 months ago (2009-04-09 18:14:14 UTC) #3

hey Will, you keep adding tabs instead of spaces to chrome.gyp. Please to be
stopping.

Expand Messages | Collapse Messages