chrome/browser/gtk/browser_window_gtk.cc - Issue 62154: Implement stop/go button for Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/browser_window_gtk.cc

Issue 62154: Implement stop/go button for Linux (Closed)

Patch Set: Add a small DCHECK => DCHECK_NE change. Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/gtk/browser_window_gtk.cc

diff --git a/chrome/browser/gtk/browser_window_gtk.cc b/chrome/browser/gtk/browser_window_gtk.cc

index 7e0e81eca79db962b9de024c4d91cb45f98474e0..d8417abaf1974778a5acc04994ec963fc3576ebd 100644

--- a/chrome/browser/gtk/browser_window_gtk.cc

+++ b/chrome/browser/gtk/browser_window_gtk.cc

@@ -20,6 +20,7 @@

#include "chrome/browser/browser_list.h"

#include "chrome/browser/gtk/bookmark_bar_gtk.h"

#include "chrome/browser/gtk/browser_toolbar_gtk.h"

+#include "chrome/browser/gtk/go_button_gtk.h"

#include "chrome/browser/gtk/infobar_container_gtk.h"

#include "chrome/browser/gtk/find_bar_gtk.h"

#include "chrome/browser/gtk/status_bubble_gtk.h"

@@ -413,8 +414,8 @@ void BrowserWindowGtk::SetFocusToLocationBar() {

}

void BrowserWindowGtk::UpdateStopGoState(bool is_loading) {

- // Need to implement stop/go button.

- // http://code.google.com/p/chromium/issues/detail?id=9381

+ toolbar_->GetGoButton()->ChangeMode(

+ is_loading ? GoButtonGtk::MODE_STOP : GoButtonGtk::MODE_GO);

}

void BrowserWindowGtk::UpdateToolbar(TabContents* contents,

« no previous file with comments | « chrome/browser/gtk/browser_toolbar_gtk.cc ('k') | chrome/browser/gtk/custom_button.h » ('j') | no next file with comments »