Find should allow keyboard scrolling while Find bar has focus

When the Find bar has focus it eats keypresses such as PageUp, PageDown and Up and Down arrow keys. It doesn't need to - instead the page should scroll even if focus is on the Find bar.

This patch forwards those selected keypresses to the page for its perusal.

Known issues: Just like Firefox, the page doesn't scroll if it has frames.

SONG=I like to fixit fixit. I like to fixit fixit.
BUG=7079
TEST=Open FindInPage on a webpage that has a vertical scrollbar. Press Down, Up, PageDown and PageUp and the page should scroll accordingly. Make sure no ding is heard while doing so. Also make sure this works if focus is on a textfield/textarea when you press Ctrl+F.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13389

[jcampan, 2009-04-08 17:35:50]

http://codereview.chromium.org/62129/diff/28/1045
File chrome/browser/renderer_host/render_widget_host.h (right):

http://codereview.chromium.org/62129/diff/28/1045#newcode170
Line 170: void ClearFocusedNode();
I think this method only belongs to RenderViewHost (since a RenderWidgetHost
does not contain any nodes).

http://codereview.chromium.org/62129/diff/28/1038
File chrome/browser/views/find_bar_view.cc (right):

http://codereview.chromium.org/62129/diff/28/1038#newcode497
Line 497: break;
Nit: remove the break

http://codereview.chromium.org/62129/diff/28/1037
File chrome/browser/views/find_bar_win.cc (right):

http://codereview.chromium.org/62129/diff/28/1037#newcode241
Line 241: RenderWidgetHostView* view = contents->render_view_host()->view();
You could simplify with:
RenderViewHost* render_view_host = contents->render_view_host();
You can then call ClearFocusedNode() on render_view_host.

http://codereview.chromium.org/62129/diff/28/1041
File chrome/browser/views/find_bar_win.h (right):

http://codereview.chromium.org/62129/diff/28/1041#newcode62
Line 62: // Forward keystrokes to the renderer. This is useful to make sure that
Nit:Forward -> Forwards

http://codereview.chromium.org/62129/diff/28/1049
File chrome/renderer/render_widget.h (right):

http://codereview.chromium.org/62129/diff/28/1049#newcode132
Line 132: void OnClearFocusedNode();
As mentioned somewhere else, this method should probably only be part of
RenderView.

[Finnur, 2009-04-08 21:13:34]

All done, I believe, and uploaded. Please take another look.

[jcampan, 2009-04-08 21:23:02]

http://codereview.chromium.org/62129/diff/74/99
File chrome/renderer/render_widget.cc (right):

http://codereview.chromium.org/62129/diff/74/99#newcode127
Line 127: IPC_MESSAGE_HANDLER(ViewMsg_ClearFocusedNode, OnClearFocusedNode)
This should be moved to RenderView.

http://codereview.chromium.org/62129/diff/74/98
File chrome/renderer/render_widget.h (right):

http://codereview.chromium.org/62129/diff/74/98#newcode132
Line 132: void OnClearFocusedNode();
This should be moved to RenderView

http://codereview.chromium.org/62129/diff/74/100
File webkit/glue/webwidget.h (right):

http://codereview.chromium.org/62129/diff/74/100#newcode64
Line 64: virtual void ClearFocusedNode() = 0;
This should be moved to WebView

http://codereview.chromium.org/62129/diff/74/103
File webkit/glue/webwidget_impl.h (right):

http://codereview.chromium.org/62129/diff/74/103#newcode49
Line 49: virtual void ClearFocusedNode();
This should be moved to WebViewImpl

[jcampan, 2009-04-08 21:47:58]

LGTM