Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2039)

Unified Diff: chrome/browser/views/find_bar_view.cc

Issue 62129: Find should allow keyboard scrolling while Find bar has focus (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/find_bar_view.h ('k') | chrome/browser/views/find_bar_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/find_bar_view.cc
===================================================================
--- chrome/browser/views/find_bar_view.cc (revision 13375)
+++ chrome/browser/views/find_bar_view.cc (working copy)
@@ -473,11 +473,11 @@
}
}
-void FindBarView::HandleKeystroke(views::TextField* sender, UINT message,
+bool FindBarView::HandleKeystroke(views::TextField* sender, UINT message,
TCHAR key, UINT repeat_count, UINT flags) {
// If the dialog is not visible, there is no reason to process keyboard input.
if (!container_->IsVisible())
- return;
+ return false;
switch (key) {
case VK_RETURN: {
@@ -491,7 +491,18 @@
}
break;
}
+#if defined(OS_WIN)
+ // TODO(port): Handle this for other platforms.
+ case VK_UP:
+ case VK_DOWN:
+ case VK_PRIOR: // Page up
+ case VK_NEXT: // Page down
+ container_->ForwardKeystrokeToWebpage(key);
+ return true; // Message has been handled. No further processing needed.
+#endif
}
+
+ return false;
}
void FindBarView::ResetMatchCountBackground() {
« no previous file with comments | « chrome/browser/views/find_bar_view.h ('k') | chrome/browser/views/find_bar_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698