Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: build/java_apk.gypi

Issue 621263003: Move version branding to before relocation packing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/insert_chromium_version.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index fbc5a3af1bd47879821dab8fa15467acca039c81..1b90a1b4b6e2dea69c49c41282e7327f7e7683b5 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -342,6 +342,19 @@
'includes': ['../build/android/strip_native_libraries.gypi'],
},
{
+ 'action_name': 'insert_chromium_version',
+ 'variables': {
+ 'ordered_libraries_file%': '<(ordered_libraries_file)',
+ 'stripped_libraries_dir%': '<(stripped_libraries_dir)',
+ 'version_string': '<(native_lib_version_name)',
+ 'input_paths': [
+ '<(strip_stamp)',
+ ],
+ 'stamp': '<(version_stamp)'
+ },
+ 'includes': ['../build/android/insert_chromium_version.gypi'],
+ },
+ {
'action_name': 'pack_arm_relocations',
'variables': {
'conditions': [
@@ -358,26 +371,13 @@
'stripped_libraries_dir%': '<(stripped_libraries_dir)',
'packed_libraries_dir': '<(libraries_source_dir)',
'input_paths': [
- '<(strip_stamp)',
+ '<(version_stamp)'
],
'stamp': '<(pack_arm_relocations_stamp)',
},
'includes': ['../build/android/pack_arm_relocations.gypi'],
},
{
- 'action_name': 'insert_chromium_version',
- 'variables': {
- 'ordered_libraries_file%': '<(ordered_libraries_file)',
- 'libraries_source_dir%': '<(libraries_source_dir)',
- 'version_string': '<(native_lib_version_name)',
- 'input_paths': [
- '<(pack_arm_relocations_stamp)',
- ],
- 'stamp': '<(version_stamp)'
- },
- 'includes': ['../build/android/insert_chromium_version.gypi'],
- },
- {
'variables': {
'input_libraries': [
'<@(additional_bundled_libs)',
@@ -476,7 +476,7 @@
'inputs': [
'<(ordered_libraries_file)',
'<(strip_additional_stamp)',
- '<(version_stamp)',
+ '<(pack_arm_relocations_stamp)',
],
'input_apk_path': '<(unsigned_apk_path)',
'output_apk_path': '<(unsigned_standalone_apk_path)',
@@ -493,7 +493,7 @@
'libraries_source_dir': '<(apk_package_native_libs_dir)/<(android_app_abi)',
'package_input_paths': [
'<(strip_additional_stamp)',
- '<(version_stamp)',
+ '<(pack_arm_relocations_stamp)',
],
},
}],
« no previous file with comments | « build/android/insert_chromium_version.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698