A Sign in to GAIA test utility.

chrome/browser/sync/test/integration/signin_test_utils.h

Index: chrome/browser/sync/test/integration/signin_test_utils.h
diff --git a/chrome/browser/sync/test/integration/signin_test_utils.h b/chrome/browser/sync/test/integration/signin_test_utils.h
new file mode 100644
index 0000000000000000000000000000000000000000..56c1feb33e41f65913353ef91a9745202b774739
--- /dev/null
+++ b/chrome/browser/sync/test/integration/signin_test_utils.h
@@ -0,0 +1,16 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_SIGNIN_TEST_UTILS_H_
+#define CHROME_BROWSER_SYNC_TEST_INTEGRATION_SIGNIN_TEST_UTILS_H_
+
+class Browser;
+

[pval...(no longer on Chromium), 2014/11/07 23:54:14]

For consistency, let's do the following:

1) Rename this file signin_helper.
2) Put this code in a signin_helper namespace.

[shadi, 2014/11/08 01:37:57]

Done.

+// A static function which signs in a user using Chrome sign-in process.

[pval...(no longer on Chromium), 2014/11/07 23:54:14]

this isn't marked static

[shadi, 2014/11/08 01:37:57]

Yeah it should not be static.

+// This will connect to GAIA servers and kick in a sync cycle.
+bool SignInToGAIA(Browser* browser,

[pval...(no longer on Chromium), 2014/11/07 23:54:14]

what do you think about renaming this to SignIn or SignInWithUI?

[shadi, 2014/11/08 01:37:57]

Done.

+                  const std::string& username,

[Nicolas Zea, 2014/11/07 23:55:48]

I'm surprised you don't have to declare string?

[shadi, 2014/11/08 01:37:57]

Yeah, the compiler did not complain probably because the cc file has it included
in one of its .h files. I added #include <string> for correctness anyway :).

+                  const std::string& password);
+
+#endif  // CHROME_BROWSER_SYNC_TEST_INTEGRATION_SIGNIN_TEST_UTILS_H_