chrome/browser/sync/test/integration/signin_test_utils.h - Issue 621153002: A Sign in to GAIA test utility.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sync/test/integration/signin_test_utils.h

Issue 621153002: A Sign in to GAIA test utility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sign in with chrome://chrome-signin Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_SIGNIN_TEST_UTILS_H_

	6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_SIGNIN_TEST_UTILS_H_

	7

	8 class Browser;

	9
	pval...(no longer on Chromium) 2014/11/07 23:54:14 For consistency, let's do the following: 1) Renam For consistency, let's do the following: 1) Rename this file signin_helper. 2) Put this code in a signin_helper namespace. shadi 2014/11/08 01:37:57 Done. Show quoted text On 2014/11/07 23:54:14, pvalenzuela wrote: > For consistency, let's do the following: > > 1) Rename this file signin_helper. > 2) Put this code in a signin_helper namespace. Done.
	10 // A static function which signs in a user using Chrome sign-in process.
	pval...(no longer on Chromium) 2014/11/07 23:54:14 this isn't marked static this isn't marked static shadi 2014/11/08 01:37:57 Yeah it should not be static. Show quoted text On 2014/11/07 23:54:14, pvalenzuela wrote: > this isn't marked static Yeah it should not be static.
	11 // This will connect to GAIA servers and kick in a sync cycle.

	12 bool SignInToGAIA(Browser* browser,
	pval...(no longer on Chromium) 2014/11/07 23:54:14 what do you think about renaming this to SignIn or what do you think about renaming this to SignIn or SignInWithUI? shadi 2014/11/08 01:37:57 Done. Show quoted text On 2014/11/07 23:54:14, pvalenzuela wrote: > what do you think about renaming this to SignIn or SignInWithUI? Done.
	13 const std::string& username,
	Nicolas Zea 2014/11/07 23:55:48 I'm surprised you don't have to declare string? I'm surprised you don't have to declare string? shadi 2014/11/08 01:37:57 Yeah, the compiler did not complain probably becau Show quoted text On 2014/11/07 23:55:48, Nicolas Zea wrote: > I'm surprised you don't have to declare string? Yeah, the compiler did not complain probably because the cc file has it included in one of its .h files. I added #include <string> for correctness anyway :).
	14 const std::string& password);

	15

	16 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_SIGNIN_TEST_UTILS_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/signin_test_utils.cc » ('j') | chrome/browser/sync/test/integration/signin_test_utils.cc » ('J')