Issue 621073002: Revert of GrContext::copyTexture->GrContext::copySurface. Add a flush writes pixel ops flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 621073002: Revert of GrContext::copyTexture->GrContext::copySurface. Add a flush writes pixel ops flag. (Closed)

Created:
6 years, 2 months ago by bsalomon

Modified:
6 years, 2 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of GrContext::copyTexture->GrContext::copySurface. Add a flush writes pixel ops flag. (patchset #3 id:40001 of https://codereview.chromium.org/622663002/) Reason for revert: Breaking GMs on some bots Original issue's description: > GrContext::copyTexture->GrContext::copySurface. > > Add a flush writes pixel ops flag. > > Add an explicit flush writes for GrSurface. > > BUG=skia:2977 > > Committed: https://skia.googlesource.com/skia/+/cf99b00980b6c9c557e71abf1a7c9f9b21217262 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2977 Committed: https://skia.googlesource.com/skia/+/85d3427d4932c6cfaf02f8a7454f0c6f213b0c2e

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -103 lines)			Patch
M	include/gpu/GrContext.h	View	2 chunks	+11 lines, -35 lines	0 comments	Download
M	include/gpu/GrSurface.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	7 chunks	+24 lines, -41 lines	0 comments	Download
M	src/gpu/GrSurface.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/gpu/SkGrPixelRef.cpp	View	2 chunks	+15 lines, -13 lines	0 comments	Download
M	src/image/SkSurface_Gpu.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

Created Revert of GrContext::copyTexture->GrContext::copySurface. Add a flush writes pixel ops flag.

6 years, 2 months ago (2014-10-02 18:22:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621073002/1

6 years, 2 months ago (2014-10-02 18:22:48 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-02 18:23:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 85d3427d4932c6cfaf02f8a7454f0c6f213b0c2e