LayoutTests/svg/custom/path-domsubtreemodified-crash.html - Issue 62083002: Remove support for the externalResourcesRequired attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/custom/path-domsubtreemodified-crash.html

Issue 62083002: Remove support for the externalResourcesRequired attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/custom/loadevents-normal-displaynone.svg ('k') | LayoutTests/svg/custom/svg-features-expected.txt » ('j') | Source/core/dom/DOMImplementation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/custom/path-domsubtreemodified-crash.html

diff --git a/LayoutTests/svg/custom/path-domsubtreemodified-crash.html b/LayoutTests/svg/custom/path-domsubtreemodified-crash.html

index 1cbbc8272561fe6e682d4ab06025d58b64d827ed..db77311ba4ffc07ebbc5a7228b746dc18f691099 100644

--- a/LayoutTests/svg/custom/path-domsubtreemodified-crash.html

+++ b/LayoutTests/svg/custom/path-domsubtreemodified-crash.html

@@ -29,7 +29,8 @@

function doCrash() {

var farthestViewportElement = defs["farthestViewportElement"];

var externalResourcesRequired = farthestViewportElement["externalResourcesRequired"];

- externalResourcesRequired["baseVal"] = undefined;

+ if (externalResourcesRequired)

+ externalResourcesRequired["baseVal"] = undefined;

Stephen Chennney 2013/11/06 16:45:43 I think you can remove this test and its result. I

Erik Dahlström (inactive) 2013/11/07 09:38:04 fine by me, I was unsure what to do with it since

body.offsetWidth;

body.innerHTML = "FAIL";

}